New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qspi hal test refactoring/update #7925

Merged
merged 6 commits into from Sep 21, 2018

Conversation

Projects
None yet
5 participants
@maciejbocianski
Member

maciejbocianski commented Aug 29, 2018

Description

  • code refactoring and preparation for enabling DPI/QPI tests
  • add DPI and QPI support
  • reduced multiple test count to 4
  • use common flash config header for all MX25RXX35F chips
  • fix sector erase max time on N25Q128A
  • randomize flash address during test to extend flash life (CI boards)

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
qspi_hal_test refactoring
- code refactoring and preparation for enabling DPI/QPI tests
- reduced multiple test count to 4
- use common flash config header for all MX25RXX35F chips
- fix sector erase max time on N25Q128A
@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Aug 29, 2018

@0xc0170 0xc0170 requested review from offirko, jamesbeyond and SenRamakri Aug 29, 2018

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:qspi_hal_test_refactoring branch from 58cb363 to 4e5fd07 Aug 29, 2018

maciejbocianski added some commits Aug 29, 2018

qspi_hal_test - randomize flash RW addres
randomize flash address during test to extend flash life

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:qspi_hal_test_refactoring branch from 4e5fd07 to b41ce6c Aug 29, 2018

@offirko

Looks good to me

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Aug 30, 2018

Tested on:

DISCO_F413ZH 
DISCO_L475VG_IOT01A
EFM32GG11_STK3701
NRF52840_DK 
@0xc0170

test utils look like they might become driver update or keep driver as it is ?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 30, 2018

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Aug 30, 2018

Don't know why, but on nrf52840_dk only first 16 sectors of MX25R6435F are writable (checked: no protection was enabled).
Patch for test: use only first 16 blocks during test def7ee1

@0xc0170
There was a bug in qspi_command_transfer function, address was send LSB first but should be MSB first
Fix for this: 3a64383

fix qspi address sending for nrf52
fix address sending in qspi_command_transfer
now address is send MSB first

@maciejbocianski maciejbocianski force-pushed the maciejbocianski:qspi_hal_test_refactoring branch from def7ee1 to 3a64383 Aug 31, 2018

qspi_hal_test - adjust used memory sector count
set flash sector count to 1024 for EFM32GG11_STK3701(MX25R3235F)
set flash sector count to 2048 for NRF52840_DK(MX25R6435F)
@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Aug 31, 2018

@0xc0170 @jamesbeyond @offirko
please review again, two commits were added
3a64383
cffd581

@jamesbeyond

Looks good to me

@offirko

offirko approved these changes Sep 1, 2018

Fix for address MSB first looks good

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3092
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7925/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Sep 19, 2018

tests-mbed_drivers-lp_ticker
NUCLEO_F746ZG - Toolchain: GCC_ARM

[1537279728.87][CONN][RXD] >>> Running case #11: 'Test multi ticker'... 
[1537279728.97][CONN][INF] found KV pair in stream: {{__testcase_start;Test multi ticker}}, queued... 
[1537279729.17][CONN][RXD] :83::FAIL: Expected 16 Was 32 
[1537279729.27][CONN][INF] found KV pair in stream: {{__testcase_finish;Test multi ticker;0;1}}, queued... 
[1537279729.37][CONN][RXD] >>> 'Test multi ticker': 0 passed, 1 failed with reason 'Assertion Failed'

I'm looking into it

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

@maciejbocianski Let us know if you find anything, we should restart CI here

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 21, 2018

@0xc0170 0xc0170 merged commit 6a34251 into ARMmbed:master Sep 21, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 565 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9186 cycles (-79 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment