New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export, MCUXpresso: Avoid assigning self.libraries #7937

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Aug 30, 2018

Description

At some point in the past, self.libraries was changed from "assignable"
to not allowing assignment. This PR changes the MCUXpresso exporter to
avoid assigning this variable, and therefore fixes the exporter.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 30, 2018

I assume branch was created from dm subcommand one not master (extra commits here?) ?

@cmonr cmonr self-requested a review Aug 30, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 30, 2018

Just gonna wait until #7844 comes in, since that will collapse the PR changeset.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

Just gonna wait until #7844 comes in, since that will collapse the PR changeset.

@cmonr Please review, 7844 was integrated

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 26, 2018

Looking at the history, might need a rebase to clean it

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 3, 2018

Rebasing. For some reason I did not get emails from this thread.

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:fix-mcuxpresso-lib-use branch from ff243b6 to 121130e Oct 3, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 3, 2018

@0xc0170 Rebase done.

@cmonr

cmonr approved these changes Oct 8, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Oct 8, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3298
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7937/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 10, 2018

@cmonr passed CI, but only your review, does this require a tech-lead to move to "ready to merge"?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 10, 2018

@NirSonnenschein
@theotherjimmy is effectively the tools tech lead. If we really want, we could ask @bridadan to also look, but when I'm not doing maintainer-y things, my time is spent working on tools :)

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 10, 2018

@cmonr , I get all of what you are saying and if you are ok with this then it is fine.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 10, 2018

@cmonr cmonr merged commit 1eaa8a5 into ARMmbed:master Oct 10, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 652 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9123 cycles (-1089 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment