New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export, Embitz: Avoid assigning `self.resources.linker_script` #7939

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Aug 30, 2018

Description

At some point in the past, self.linker_script was changed from
"assignable" to not allowing assignment. This PR changes the Embitz
exporter to avoid assigning this variable, and therefore fixes the
exporter. This change also simplifies the expoter code

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
SImplify linkerscirpt usage
Avoids assigning to things that we can't assign

@cmonr cmonr added the needs: CI label Aug 30, 2018

@cmonr

cmonr approved these changes Aug 30, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

Strange that this temp file error is starting to show up...

ToolException: Fatal error: A1023E: File "/tmp/file44uSrI" could not be opened: No such file or directory

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3019
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7939/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2018

License server problem

cc @OPpuolitaival

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

Another ARM network license issue.
Fyi @ARMmbed/mbed-os-test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 27f3fd9 into ARMmbed:master Sep 6, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 558 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9139 cycles (-717 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment