New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Memory overrun correction #7982

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
8 participants
@hasnainvirk
Contributor

hasnainvirk commented Sep 4, 2018

Description

A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
LoRaWAN: Memory overrun correction
A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.
@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 4, 2018

@0xc0170 @kjbracey-arm Please review. This needs immediate CI and merge.

@0xc0170

0xc0170 approved these changes Sep 4, 2018

@0xc0170 0xc0170 added the needs: CI label Sep 4, 2018

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 10, 2018

@0xc0170 @cmonr This one is still lingering here ?

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Sep 10, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 10, 2018

Build : SUCCESS

Build number : 3042
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7982/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 10, 2018

@cmonr @0xc0170 The failure is not related to this PR. Please re-run CI.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 10, 2018

@hasnainvirk Will restart both export and test CI in a bit. Current queues a bit long.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 12, 2018

@cmonr Have we missed this again ?? This is a broken , we must get this PR in as fast as we can. It's been about 8 days now, this PR is just a one liner !

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 12, 2018

@hasnainvirk We missed this because we've been prioritizing PRs needed for 5.10 RCs.

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 14, 2018

@cmonr Could you please reconsider this to be part of 5.10.0? This is a quite bad memory corruption bug.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Sep 14, 2018

@cmonr This must go in as soon as possible. Please prioritise.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Sep 14, 2018

@ChiefBureaucraticOfficer Could you please let us know if you think this should come in to 5.10 as requested by @hasnainvirk . AFAIK it has not been seen in OOB so would technically not normally be considered.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

If this is not critical/blocker, this will go 5.10.1. This is now going in, the label can be updated on request.

@0xc0170 0xc0170 merged commit aca7740 into ARMmbed:master Sep 17, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9145 cycles (-1127 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment