New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DISCO_L475VG_IOT01A remove old QSPI pins #7990

Merged
merged 1 commit into from Sep 7, 2018

Conversation

Projects
None yet
5 participants
@maciejbocianski
Member

maciejbocianski commented Sep 5, 2018

Description

clean up old QSPI pins names for DISCO_L475VG_IOT01A
QSPI_PIN_XXX was replaced by QSPI_FLASHn_XXX

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Sep 5, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Sep 5, 2018

We should also remove all QSPI_PIN_IOx pins
(as QSPI_FLASH1_xxx is the used pins) ?

@maciejbocianski

This comment has been minimized.

Member

maciejbocianski commented Sep 5, 2018

@jeromecoutant it has been already done, see #7817

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Sep 5, 2018

OK, I have added my comments in #7817
@LMESTM

@0xc0170

0xc0170 approved these changes Sep 5, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3026
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7990/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 7, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 7, 2018

@0xc0170 0xc0170 merged commit e30435b into ARMmbed:master Sep 7, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9855 cycles (+729 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment