New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting PinNames.h after PR #7774 changes #7995

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
9 participants
@yossi2le
Contributor

yossi2le commented Sep 5, 2018

Description

In PR #7774 we have changed PinNames.h for various targets. Unfortunately, this was a mistake and those changes should not be done by us. Therefore this PR initiate a revert for those file.
We will open a discussion with the relevant stakeholders to enable this change in the future.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Changes in PR #7774 of PinNames.h should be reverted. This commit rev…
…erts those files excpet for K82F and K64F which are left as an example
@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 5, 2018

@jeromecoutant Good with this revert?

Due to the time constraints of when this needs to get into RC2, we only have about 24 hrs to get an OK from partners.

@bcostm

bcostm approved these changes Sep 6, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2018

/morph build

@0xc0170

0xc0170 approved these changes Sep 6, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-storage Sep 6, 2018

@davidsaada

Looks good.

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3021
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7995/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit ff1a0ed into ARMmbed:master Sep 6, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10235 cycles (+1109 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Sep 6, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Sep 24, 2018

Hi

#7774 added SPI_PERSISTENT_MEM_CS in 31 targets
This PR removed it from 28 targets...

Why did you keep 3 of them ?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 24, 2018

@yossi2le @ARMmbed/mbed-os-storage Thoughts to the above question?

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented Sep 25, 2018

We revert the PinNames.h files after #7774 because we haven't communicated it so well with all the relevant partners and teams. After #7774 was merged there was some discussion regarding this change and AFAIK it was decided that we leave K82F and K64F boards as an example, while we start the correct procedure of adding those pins into the PinsNames.h. This procedure should be done by conducting a proper dialogue with all the relevant partners and teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment