New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nanostack mac tester and testcases #7996

Merged
merged 8 commits into from Oct 6, 2018

Conversation

Projects
None yet
10 participants
@JuhPuur
Contributor

JuhPuur commented Sep 5, 2018

Description

Add the nanostack MAC tester to test applications and testcases.
Target 5.10-RC2 / 5.10.1

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Feature
[ ] Breaking change
@mikter

This comment has been minimized.

Contributor

mikter commented Sep 5, 2018

@artokin @OPpuolitaival @kjbracey-arm can you check these changes

@mikter

looks good for me

@@ -13,5 +13,6 @@
"6LOWPAN_ROUTER" : "6lowpanInterface_router.json",
"THREAD_END_DEVICE" : "ThreadInterface_end_device.json",
"THREAD_ROUTER" : "ThreadInterface_router.json",
"NO_NETWORK": "no_network.json"
"NO_NETWORK": "no_network.json",
"MAC_TESTER": "MACTester.json"

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Sep 5, 2018

Contributor

I would say "MAC tester" may be clear enough in context of Nanostack, but is too generic for Mbed OS as a whole - the name should say something about Nanostack or 802.15.4

This comment has been minimized.

@JuhPuur

JuhPuur Sep 7, 2018

Contributor

I'm fine with changing it to something like NanostackMACTester.json

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 17, 2018

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 17, 2018

Please review the build failures (some are related to the changes)

@JuhPuur

This comment has been minimized.

Contributor

JuhPuur commented Sep 17, 2018

Rebased the branch. Weird stuff started happening when I tried to recreate that disappeared after rebasing.

@JuhPuur JuhPuur referenced this pull request Sep 18, 2018

Merged

Fixed test-config name #742

@cmonr cmonr added needs: CI and removed needs: work labels Sep 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 22, 2018

del self.th
self.reset_dut()
if __name__=='__main__':

This comment has been minimized.

@jupe

jupe Sep 22, 2018

Contributor

i dont think user are able to run individual test anymore directly, maybe better to remove these blocks

This comment has been minimized.

@JuhPuur

JuhPuur Sep 23, 2018

Contributor

Good idea.

@cmonr cmonr added needs: work and removed needs: CI labels Sep 22, 2018

@JuhPuur

This comment has been minimized.

Contributor

JuhPuur commented Sep 23, 2018

KW24D has this:
[Error] mbed_trace.h@435,45: 'dont_use_trace_helpers_outside_trace_calls' was not declared in this scope

KW41Z has this:
[DEBUG] Errors: /builds/ws/mbed-os-build-matrix/3124/KW41Z_GCC_ARM/sources/mbed-os/./TEST_APPS/device/nanostack_mac_tester/main.cpp:92: undefined reference to `NanostackRfPhy::get_default_instance()'

I don't understand why the first one appears, and the second one is weird since that change should be included already.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

/morph build

@JuhPuur

This comment has been minimized.

Contributor

JuhPuur commented Oct 1, 2018

Sorry about the delay. It's obvious that the application won't compile without its specific test config, so I set it to skip by default. Should have done that from the beginning. Should be done now.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 1, 2018

@JuhPuur JuhPuur force-pushed the JuhPuur:feature_mactester branch from f805597 to 39328af Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 2, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

looks like a build issue related tot he PR, please take a look.

@JuhPuur

This comment has been minimized.

Contributor

JuhPuur commented Oct 5, 2018

I don't think it's related to the PR. One failure for one target for one compiler, when the application added by the PR isn't compiled. The error logs have disappeared so i can't tell what was the actual cause.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

Looks like CI cleanup was not done properly, restarting

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 5, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 5, 2018

Build : SUCCESS

Build number : 3247
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7996/

Triggering tests

/morph test
/morph mbed2-build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph export-build

@0xc0170 0xc0170 changed the title from Added nanostack mac tester and testcases to Add nanostack mac tester and testcases Oct 5, 2018

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 5a8c63a into ARMmbed:master Oct 6, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(-76 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 628 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10326 cycles (+86 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 6, 2018

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Oct 9, 2018

This PR's use of thread flags just showed up while rebasing #7980 - didn't notice it at the time.

In case you ever touch this again, all the stuff about manual thread flags and rawserial and interrupt handlers and rx_buffer should no longer be needed - like some other test apps that have already been converted you can just use getchar as long as you configure platform.stdio-buffered-serial on.

Also makes the app nominally portable to a device using something other than serial console I/O.

@kjbracey-arm

This comment has been minimized.

Contributor

kjbracey-arm commented Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment