New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix whitelist generation (set correct address type) #8005

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
5 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Sep 5, 2018

Description

Whitelist generation creates a list of addresses based on the existing bonds. The addresses can be of different types but the only way to identify a random address from a public address is through a separate bit of information (not contained in the address). During whitelist generation the wrong address type was read and creating the whitelist resulted in the wrong type of address being written.

Was read:
type of address connected to
should be read:
type of identity address

Bug was detected by existing test SM_whitelist_generation_test_01 (which are not yet part of CI).

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm requested review from donatieng and pan- Sep 5, 2018

@pan-

pan- approved these changes Sep 5, 2018

Good catch.

@paul-szczepanek-arm paul-szczepanek-arm changed the title from fix whitelist generation (set correct address type) to BLE: fix whitelist generation (set correct address type) Sep 5, 2018

@cmonr cmonr added the needs: review label Sep 5, 2018

@0xc0170

0xc0170 approved these changes Sep 6, 2018

@pan-

This comment has been minimized.

Member

pan- commented Sep 7, 2018

@cmonr Not sure why you added need review after it's been reviewed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 7, 2018

@pan- Whoops, my bad. Changeset was tiny, so one OK should have been fine.

@cmonr cmonr added needs: CI and removed needs: review labels Sep 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 23, 2018

Build : SUCCESS

Build number : 3133
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8005/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 23, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit f0c6a66 into ARMmbed:master Sep 24, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.09%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10253 cycles (+34 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment