New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SD - Add required header file and namespace element instead add all #8006

Merged
merged 2 commits into from Oct 1, 2018

Conversation

Projects
None yet
6 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Sep 5, 2018

Description

Source inside mbed-os should not be using "mbed.h" even in CPP files, instead required header file and namespace should be explicitly added inside mbed-os

With #7760 PR, we will give an option to remove namespace.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr added the needs: review label Sep 6, 2018

@cmonr cmonr requested a review from ARMmbed/mbed-os-storage Sep 6, 2018

@yossi2le

Looks good to me.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 29, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 29, 2018

Build : SUCCESS

Build number : 3191
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8006/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Sep 29, 2018

@0xc0170 0xc0170 merged commit 6f338f8 into ARMmbed:master Oct 1, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9146 cycles (-1073 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment