New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTCORE-389 - bring back legacy alignment for Arm C6 #8012

Merged
merged 1 commit into from Sep 6, 2018

Conversation

Projects
None yet
6 participants
@JanneKiiskila
Contributor

JanneKiiskila commented Sep 5, 2018

Description

Quite a few of the scatter files are not (yet) aligned to 8-byte
boundaries and therefore the removal of legacy alignment feature
(which is under deprecation warning, but it actually not YET
deprecated) broke quite a few builds to this error:

Error: L6244E: Exec region RW_IRAM1 address (0x200001ac) not aligned on a 8 byte boundary.

We must bring this option now back to fix the builds.

This option to ld (--legacyalign) can only be removed once all of
the scatter files have been fixed.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
IOTCORE-389 - bring back legacy alignment for Arm C6
Quite a few of the scatter files are not (yet) aligned to 8-byte
boundaries and therefore the removal of legacy alignment feature
(which is under deprecation warning, but it actually not YET
deprecated) broke quite a few builds to this error:

Error: L6244E: Exec region RW_IRAM1 address (0x200001ac) not aligned on a 8 byte boundary.

We must bring this option now back to fix the builds.

This option to ld (--legacyalign) can only be removed once all of
the scatter files have been fixed.
@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Sep 5, 2018

@0xc0170 @adbridge @kjbracey-arm - this needs to get in ASAP, please. To next Mbed OS 5.10 RC.

@cmonr cmonr requested a review from deepikabhavnani Sep 6, 2018

@cmonr

cmonr approved these changes Sep 6, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 6, 2018

@JanneKiiskila In the future, you can simply use @ARMmbed/mbed-os-maintainers as a shorthand.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3018
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8012/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 6, 2018

/morph export-build

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Sep 6, 2018

Thanks for the fix @JanneKiiskila. @cmonr and @studavekar can we expand ARMC6 CI testing to build all boards so we can catch regressions like this?

@0xc0170

0xc0170 approved these changes Sep 6, 2018

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 5d2f394 into ARMmbed:master Sep 6, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 597 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10250 cycles (+31 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Sep 6, 2018

@JanneKiiskila JanneKiiskila deleted the JanneKiiskila:armc6-align-fix branch Sep 6, 2018

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Sep 6, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment