New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of execute region to 8byte boundary #8024

Merged
merged 13 commits into from Oct 10, 2018

Conversation

Projects
None yet
8 participants
@deepikabhavnani
Contributor

deepikabhavnani commented Sep 6, 2018

Description

Resolves: #8004

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr added the needs: review label Sep 6, 2018

@cmonr cmonr requested review from JanneKiiskila and 0xc0170 Sep 6, 2018

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:fix_align branch from fe9a724 to 33a4e0f Sep 7, 2018

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:fix_align branch from 33a4e0f to 483e02f Sep 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

Why was #8186 created separately ? Not part of this update?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

One question, all device should have this alignment for the upcoming release so we should coordinate it all works and its updated (thus my above question about nxp one).

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Sep 24, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 24, 2018

@0xc0170 - Targets having more then 25 linker files were added into new PR so that respective teams can review. We have separate PR for NXP/Freescale #8186 and ST #8013.

I can merge all of them, but thought instead of 200+ file updates in single PR it is good to have target specific and again I didn't wanted to add PR per target also :-)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

OK, I was not certain as they were not linked and I discovered all of them going through PRs. Let's review all of them and make sure all targets the same release.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 24, 2018

All of them are linked to issue #8004 and not each other.

@0xc0170

This comment has been minimized.

@c1728p9

c1728p9 approved these changes Oct 3, 2018

In addition to changing the '.sct' files to fix ARMC6 alignment it looks like the '.ld' and '.icf' files were also updated. Was this causing a problem or is this just for consistency?

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Oct 3, 2018

In addition to changing the '.sct' files to fix ARMC6 alignment it looks like the '.ld' and '.icf' files were also updated. Was this causing a problem or is this just for consistency?

just for consistency :-( . IAR files were actually mostly 8-byte aligned for all sections, except vectors

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:fix_align branch from 483e02f to 7fca9f5 Oct 8, 2018

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Oct 8, 2018

Rebased to resolve conflicts

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Oct 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2018

@cmonr cmonr added needs: work and removed needs: CI labels Oct 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

It's not the easiest thing to tell from the log, but there's a syntax error with the EFM32PG12_STK3402 target when compiling with GCC, on line 7.

SiLabs: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary

deepikabhavnani added some commits Sep 19, 2018

Nuvoton: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Nordic: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Toshiba: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Atmel: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Maxim: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
ARM: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Renesas: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Analog Devices: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Onsemi: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Wiznet: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Realtek: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
Ublox: Fix alignment of execute region to 8-byte boundary
--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to
remove deprecated flags all linker files (GCC and IAR as well to have uniformity)
should strictly align to 8-byte boundary
@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Oct 9, 2018

It's not the easiest thing to tell from the log, but there's a syntax error with the EFM32PG12_STK3402 target when compiling with GCC, on line 7.

Missed semicolon in linker file.. Will amend the commit, hence listing here the change

-__vector_size = 0x110
+__vector_size = 0x110;

@deepikabhavnani deepikabhavnani force-pushed the deepikabhavnani:fix_align branch from 7fca9f5 to 08051f5 Oct 9, 2018

@cmonr cmonr added needs: CI and removed needs: work labels Oct 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3297
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8024/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 10, 2018

@cmonr cmonr merged commit ab064df into ARMmbed:master Oct 10, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 653 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9124 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 10, 2018

@deepikabhavnani deepikabhavnani deleted the deepikabhavnani:fix_align branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment