New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with LowPowerTickerWrapper #8029

Merged
merged 1 commit into from Sep 19, 2018

Conversation

Projects
None yet
5 participants
@ccli8
Contributor

ccli8 commented Sep 7, 2018

Description

On all Nuvoton targets, LPTICKER_DELAY_TICKS is enabled which relies on LowPowerTickerWrapper. This PR tries to fix some corner case errors with LowPowerTickerWrapper:

  1. _ticker_match_interval_passed doesn't see _last_set_interrupt == _cur_match_time as matched. Add extra check for it.
  2. Fix "too close" check with _min_count_until_match.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Fix issues with LowPowerTickerWrapper
1. Complement _ticker_match_interval_passed with '_last_set_interrupt == _cur_match_time' for pass check
2. Fix 'too close' check with _min_count_until_match
@c1728p9

Thanks for the fix @ccli8. @cmonr this is something you'll probably want for 5.10.1

@cmonr cmonr added needs: CI and removed needs: review labels Sep 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 19, 2018

Thanks for the heads up. Initially missed it since the Nuvoton PRs have generally had something in the totle indicating as such.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3103
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8029/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 19, 2018

@0xc0170 0xc0170 merged commit 962273c into ARMmbed:master Sep 19, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 599 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9170 cycles (-34 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@ccli8 ccli8 deleted the OpenNuvoton:nuvoton_fix_lpticker_wrapper branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment