New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: error: fix bogus usage of memset() #8036

Merged
merged 1 commit into from Sep 24, 2018

Conversation

Projects
None yet
5 participants
@TeroJaasko
Contributor

TeroJaasko commented Sep 7, 2018

Description

Code had mixed up order of 'c' and 'n' arguments to memset().
Fix this.

Spotted-by: kjbracey-arm & a GCC profile without "-fno-builtin"

Related GCC warnings:
---8<---8<----
[Warning] mbed_error.c@123,5: 'memset' used with constant zero length parameter; this could be due to transposed parameters [-Wmemset-transposed-args]
[Warning] mbed_error.c@282,5: 'memset' used with constant zero length parameter; this could be due to transposed parameters [-Wmemset-transposed-args]

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
platform: error: fix bogus usage of memset()
Code had mixed up order of 'c' and 'n' arguments to memset().
Fix this.

Spotted-by: kjbracey-arm & a GCC profile without "-fno-builtin"

Related GCC warnings:
---8<---8<----
[Warning] mbed_error.c@123,5: 'memset' used with constant zero length parameter; this could be due to transposed parameters [-Wmemset-transposed-args]
[Warning] mbed_error.c@282,5: 'memset' used with constant zero length parameter; this could be due to transposed parameters [-Wmemset-transposed-args]

@cmonr cmonr requested a review from SenRamakri Sep 7, 2018

@cmonr

cmonr approved these changes Sep 7, 2018

@cmonr cmonr requested a review from deepikabhavnani Sep 7, 2018

@cmonr cmonr added the needs: review label Sep 7, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Sep 7, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 23, 2018

Build : SUCCESS

Build number : 3134
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8036/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Sep 23, 2018

@0xc0170 0xc0170 merged commit 9506f50 into ARMmbed:master Sep 24, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10239 cycles (+1167 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@TeroJaasko TeroJaasko deleted the TeroJaasko:fix_mbed_error_c_memsets branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment