Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Clarify test configuration in Socket/Networking test document #8060
Clarify test configuration in Socket/Networking test document.
Pull request type
referenced this pull request
Sep 10, 2018
@SeppoTakalo thanks for looking into this.
I'm not able to get it working on the K64F. I'm probably missing something.
It still complains:
With the new changes you've introduced, it suggests to create a
What do you think is missing?
I've also tried the existing config with no luck:
@MarceloSalazar What you described is the correct behaviour.
K64F does not have wifi, so compiling Wifi test should fail in
Also, leaving the default interface is intentional, as K64F should provide one from the
But if you claim in the configuration that default network interface is ethernet, you force those to be build in, which would lead to linker failure, because device would not have ethernet driver.
WiFi configuration instead is meant to force the wifi to be default, because WiFi board may choose to have the Ethernet as default interface. There is no hard guideline there. It is up to the board.
The sample configuration that I provided:
Which works as expected.
mbed-os-network is network layer tests, WiFi and EMAC. Both should be skipped, because I have not supplied EMAC test parameters. WiFi skips because it is not Wifi.
thanks @SeppoTakalo . I was messing up things completely.
In order to clarify things for the users, do you think we could introduce these simple changes in the Building and Running section of the docs. Maybe merging both building and running sections but making clear what people should be running:
Building and Running
WiFi and EMAC (Ethernet)
mbed test -t -m -n mbed-os-tests-network-*
Socket tests (DNS, TCP, UDP)
mbed test -t -m -n mbed-os-tests-netsocket*
@MarceloSalazar Yes. It would make sense.
I'll keep this in mind for the next updates into this document.
@MarceloSalazar What is wrong with the form that is already written in the document: https://github.com/ARMmbed/mbed-os/blob/5e9fb0d5627a3d83add99bc1b93803108fdf2e71/TESTS/netsocket/README.md#running-tests
When device is connected to network, or in case of wireless device near the access point.
That runs both set of test cases. I don't see the point of separating the test runs.
Having a single line means everyone will have the environment and configuration ready to work straight away, which is not the case.
You see above I failed at running this on K64F (Ethernet), because I didn't have the correct configuration in place and didn't understand the pre-conditions.
I addition to splitting the lines for tests (as suggested #8060 (comment)), I really want us to add a small table with snippets of configurations for different cases (I don't think we need to create json files)
If you want, I can send a PR on top of this with the proposal.
Build number : 3079
Build number : 2690