New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes and general readability improvements for TEST_APPS documentation #8067

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
10 participants
@bridadan
Contributor

bridadan commented Sep 10, 2018

Description

This PR is part of the 5.10 OOB process.

I've included some spelling fixes and general readability improvements to the TEST_APPS documentation. None of the changes are particularly technical, I was just making tweaks as I read the document.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Copy edit readme.md
Extend copy edits.
@AnotherButler

@bridadan 👍 Thanks for the great copy edits. I've added some more on top of yours.

@bridadan

This comment has been minimized.

Contributor

bridadan commented Sep 11, 2018

Your edits look great, thanks @AnotherButler!

You probably want to add the log folder to your .mbedignore file to prevent issues with build commands becoming too long over the time.
You can also find the results from the tests in the `mbed-os/log` folder.
You probably want to add the log folder to your `.mbedignore` file to prevent issues with build commands becoming too long over the time.

This comment has been minimized.

@jupe

jupe Sep 12, 2018

Contributor

why build command touch even log files? Could it be ignored by default?

This comment has been minimized.

@cmonr

cmonr Sep 12, 2018

Contributor

@SeppoTakalo @OPpuolitaival Could y'all address this question?

This comment has been minimized.

@bridadan

bridadan Sep 12, 2018

Contributor

I believe the concern is that mbed-os/log adds another include directory to the already long list of include directories. As long as no subdirectories are added to mbed-os/log, I think it'd be safe to remove this section in the docs.

This comment has been minimized.

@SeppoTakalo

SeppoTakalo Sep 13, 2018

Contributor

If we know that its always mbed-os/log then I would be happy to add that into .mbedignore file, just to be safe.

@SeppoTakalo

Looks good.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Sep 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 16, 2018

Build : SUCCESS

Build number : 3080
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8067/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit d02cd70 into ARMmbed:master Sep 17, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9077 cycles (-1464 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment