Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Unittesting doc tweaks #8069

Closed
wants to merge 1 commit into from
Closed

Minor Unittesting doc tweaks #8069

wants to merge 1 commit into from

Conversation

kegilbert
Copy link
Contributor

Description

Addresses some of Marcelo's comments in #8058

  • Add link to troubleshooting section at the top of the page
  • Update GCC requirements for Windows users

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@kegilbert kegilbert mentioned this pull request Sep 10, 2018
Closed
cmonr
cmonr suggested changes Sep 11, 2018
View reviewed changes
UNITTESTS/README.md Outdated

## Prerequisites

* GNU toolchains installed.
* GCC 6 or later
* MinGW-W64 GCC-6.4.0 or MinGW-W64 GCC-7.3.0 (Windows)
* GCC-6.4.0 or GCC-7.3.0 (Windows)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If more detail is being added here, is the preceeding line still needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, no it is not I'll remove it

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3053
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8069/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Exporter Build : SUCCESS

Build number : 2668
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8069/

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Test : FAILURE

Build number : 2831
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8069/2831

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

NRF51 sync issue.

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

Test : SUCCESS

Build number : 2839
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8069/2839

@cmonr
Copy link
Contributor

cmonr commented Sep 13, 2018

Well this is mildly infuriating.
This PR needs a rebase...

@kegilbert
Minor UNITTEST readme tweaks
5b99158 
- Add link to troubleshooting section at the top of the page
- Update GCC requirements for Windows users
@kegilbert
Copy link
Contributor Author

@cmonr Rebased

@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Build : SUCCESS

Build number : 3126
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8069/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Test : FAILURE

Build number : 2927
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8069/2927

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Exporter Build : SUCCESS

Build number : 2734
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8069/

@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

Huh. Haven't seen that failure in a while.

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 22, 2018

Test : FAILURE

Build number : 2928
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8069/2928

@cmonr
Copy link
Contributor

cmonr commented Sep 23, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2018

Test : SUCCESS

Build number : 2937
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8069/2937

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

Final @AnotherButler approval needed

@lorjala
Copy link
Contributor

lorjala commented Sep 24, 2018

These changes are included in #8212.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

These changes are included in #8212.

I'll close this one as resolved

@0xc0170 0xc0170 closed this Sep 24, 2018
@cmonr cmonr deleted the kegilbert-patch-2 branch September 26, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@lorjala lorjala lorjala approved these changes

@AnotherButler AnotherButler Awaiting requested review from AnotherButler

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kegilbert @cmonr @mbed-ci @0xc0170 @lorjala @adbridge