New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas : Improve Flash iap driver #8072

Merged
merged 3 commits into from Oct 8, 2018

Conversation

Projects
None yet
5 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Sep 11, 2018

Description

I improved flash_api.c file of Renesas.

  • The buffer at flash write must be RAM address.
  • Shorten the interrupt disable period at flash write and flash erase.

Test result

NVStore and Flash iAP test result is here.
Test_GR-PEACH_GCC.txt
Test_GR-LYCHEE_GCC.txt

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@cmonr

cmonr approved these changes Sep 11, 2018

TomoYamanaka added some commits Sep 11, 2018

Improve Flash iap driver of Renesas
I changed _page_program() func because "buf" which is an argument of data_send() for writing must be a RAM address in order to operate in SPI mode.
(ex: if it is ROM table data, writing will be failure.)
Also, I changed the period of interrupt disable/enable at _page_program() func and _sector_erase() func because lock period is too long.
Support large Flash in Flash iap driver of Renesas
I addressed the cases Flash size is larger than 0x1000000.

@TomoYamanaka TomoYamanaka force-pushed the TomoYamanaka:improve_flashiap branch from 95ae812 to d5ef467 Sep 20, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Sep 20, 2018

I renamed the first commit and added new commit.

NVStore and Flash iAP test result is here.
Test_PEACH_GCC.txt
Test_LYCHEE_GCC.txt

Pelase review again.

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Sep 28, 2018

Sorry to bother you again. I added a commit once more.
I'm appreciate if you can review.
NVStore and Flash iAP test result is here.
Test_PEACH_GCC.txt
Test_LYCHEE_GCC.txt

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 28, 2018

Interesting. @ARMmbed/mbed-os-storage Mind taking a look at the last commit? Should be a quick review.

Revise the value of return value of flash_get_page_size()
Currently the return value of flash_get_page_size() is 1 since the min size per one writing is 1 byte by Flash spec.
However, I noticed that this value causes a enormous write time When writing large data such as FW update.
So I revised this value to 8 byte by considering the writing time, memory alignment and memory hole.

@TomoYamanaka TomoYamanaka force-pushed the TomoYamanaka:improve_flashiap branch from ffbbfcd to cb087ed Sep 28, 2018

@TomoYamanaka

This comment has been minimized.

Contributor

TomoYamanaka commented Sep 28, 2018

I modified my comment at the last commit.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3209
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8072/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

Exporters will be rerun once we find the rootcause for the failure (its affecting more PR so not related to this changeset only).

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit f5cfdfa into ARMmbed:master Oct 8, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10328 cycles (-138 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

@TomoYamanaka TomoYamanaka deleted the TomoYamanaka:improve_flashiap branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment