New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quotes around gcovr install command for Windows #8092

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
5 participants
@yennster
Contributor

yennster commented Sep 11, 2018

Description

This PR changes the gcovr install command from pip install 'gcovr>=4.1' to pip install "gcovr>=4.1" to work successfully on Windows

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@cmonr

cmonr approved these changes Sep 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 12, 2018

Nice catch. Good 'ol Command Prompt bs Git Bash difference.

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Sep 12, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 12, 2018

Build : SUCCESS

Build number : 3055
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8092/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 12, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 207ea79 into ARMmbed:master Sep 13, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9177 cycles (-1364 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment