New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lora: Fix sticky MAC command retransmissions #8096

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
6 participants
@kivaisan
Contributor

kivaisan commented Sep 12, 2018

Description

This commit fixes the bug where sticky MAC commands were duplicated in
send buffer everytime send() was called.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 12, 2018

@hasnainvirk

Looks good.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

Can you rebase? We will start CI

Lora: Fix sticky MAC command retransmission
This commit fixes the bug where sticky MAC commands were duplicated in
send buffer everytime send() was called.

@kivaisan kivaisan force-pushed the kivaisan:fix_mac_command_retransmission branch from a296b8f to 19d90bd Sep 20, 2018

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 20, 2018

@0xc0170 Rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 20, 2018

Build : SUCCESS

Build number : 3115
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8096/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 20, 2018

@kivaisan @hasnainvirk Are the functions in this file not meant to be used by application developers?

19d90bd#diff-73c4e0f308c58824d9bfaeb1900924fc

@mbed-ci

This comment has been minimized.

@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 21, 2018

@cmonr These are our stack internal methods, so supposed to be used by application directly.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 21, 2018

@cmonr These are our stack internal methods, so supposed to be used by application directly.

It's worth stating in the commit msg, to avoid later questioning the release version.

@0xc0170 0xc0170 merged commit 0c8aa28 into ARMmbed:master Sep 21, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 609 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9943 cycles (-312 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Sep 21, 2018

Sorry, just noticed one critical typo in my earlier comment, so NOT supposed to be used by application directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment