New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace macros with config options #8106

Merged
merged 1 commit into from Sep 22, 2018

Conversation

Projects
None yet
6 participants
@c1728p9
Contributor

c1728p9 commented Sep 12, 2018

Description

Add a config option for the following values:

  • MBED_SYS_STATS_ENABLED
  • MBED_STACK_STATS_ENABLED
  • MBED_CPU_STATS_ENABLED
  • MBED_HEAP_STATS_ENABLED
  • MBED_THREAD_STATS_ENABLED
  • MBED_CONF_APP_MAIN_STACK_SIZE
  • MBED_CONF_APP_TIMER_THREAD_STACK_SIZE
  • MBED_CONF_APP_IDLE_THREAD_STACK_SIZE
  • MBED_CONF_APP_THREAD_STACK_SIZE

To maintain backwards compatibility inside the RTOS both APP and RTOS config values can be used.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change
Replace macros with config options
Add a config option for the following values:
MBED_SYS_STATS_ENABLED
MBED_STACK_STATS_ENABLED
MBED_CPU_STATS_ENABLED
MBED_HEAP_STATS_ENABLED
MBED_THREAD_STATS_ENABLED
MBED_CONF_APP_MAIN_STACK_SIZE
MBED_CONF_APP_TIMER_THREAD_STACK_SIZE
MBED_CONF_APP_IDLE_THREAD_STACK_SIZE
MBED_CONF_APP_THREAD_STACK_SIZE

To maintain backwards compatibility inside the RTOS both
APP and RTOS config values can be used.
@kegilbert

Awesome, LGTM!

@cmonr cmonr added the needs: review label Sep 12, 2018

@@ -70,6 +70,31 @@
"help": "Enable tracing of each memory call by invoking a callback on each memory operation. See mbed_mem_trace.h in the HAL API for more information",
"value": false
},
"sys-stats-enabled": {
"macro_name": "MBED_SYS_STATS_ENABLED",

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Sep 14, 2018

Contributor

Setting this as macro name will set the macro? Wow I didn't knew we can actually rename long MBED_CONF parameters using this..

This comment has been minimized.

@kegilbert

kegilbert Sep 14, 2018

Contributor

Yeah it's super helpful but not a really well known feature.

@deepikabhavnani

This comment has been minimized.

Contributor

deepikabhavnani commented Sep 14, 2018

Code changes look good but we should be updating documents and all examples 'mbed-os-example-xxx' to use new parameter

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Sep 14, 2018

@deepikabhavnani I can get on that early next week if Russ doesn't beat me to it.

@c1728p9

This comment has been minimized.

Contributor

c1728p9 commented Sep 17, 2018

Example updates will need to wait until this change is in a release. @cmonr can this PR go in the next patch release?

@0xc0170

Like it having it in the config and backward compatible

@cmonr

cmonr approved these changes Sep 20, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 22, 2018

Build : SUCCESS

Build number : 3123
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8106/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 1a638c7 into ARMmbed:master Sep 22, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10045 cycles (-145 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment