New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gt netsocket tcp - increases threads' stack size #8132

Merged
merged 3 commits into from Sep 27, 2018

Conversation

Projects
None yet
6 participants
@VeijoPesonen
Contributor

VeijoPesonen commented Sep 14, 2018

Description

Greentea netsocket tcp test cases - used thread stack size was insufficient for debug profile.
Also insufficient thread stack size with NUCLEO_F401RE+IDW01M1 - please see issue ARMmbed/wifi-x-nucleo-idw01m1#17

Test case timeout value increased because demanded by the new ARMmbed/esp8266-driver#83

Patch (commit) 24905f5 provided by @betzw.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 14, 2018

@betzw, @juhaylinen - includes everything required by ARMmbed/wifi-x-nucleo-idw01m1#17? @kjbracey-arm, @SeppoTakalo please review.

@betzw

betzw approved these changes Sep 14, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3110
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8132/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 20, 2018

Hmm, I claim this one:

BUILD/tests/ARCH_PRO/GCC_ARM/TESTS/netsocket/tcp/tcp.bin , TCPSOCKET_ECHOTEST_NONBLOCK - might be that the stack size got too big

Other failures, not caused by these test case changes:

BUILD/tests/LPC546XX/GCC_ARM/TESTS/mbed_drivers/crc/crc.bin , tests-mbed_drivers-crc
BUILD/tests/LPC546XX/ARM/TESTS/netsocket/dns/dns.bin , tests-netsocket-dns
BUILD/tests/LPC546XX/ARM/TESTS/netsocket/dns/dns.bin , features-frameworks-utest-tests-unit_tests-case_control_async
BUILD/tests/LPC546XX/IAR/TESTS/mbed_hal/us_ticker/us_ticker.bin , tests-mbed_hal-us_ticker

BUILD/tests/NUCLEO_F746ZG/ARM/TESTS/mbed_drivers/lp_ticker/lp_ticker.bin , tests-mbed_drivers-lp_ticker

@cmonr cmonr added needs: work and removed needs: CI labels Sep 20, 2018

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 21, 2018

@betzw could you check if 2048B as stack size is sufficient with NUCLEO_F401RE? It seems to be enough for debug profile with K64F.

@betzw

This comment has been minimized.

Contributor

betzw commented Sep 21, 2018

Well, I will check, but what I can already say is that I know of some demo application (e.g. mbed_cloud_client) where a stack size of 4K was necessary!
Btw, I think that stack size is less dependent on the board/chip but typically much more on the application you run. It might be that a stack overflow on the NUCLEO_F401RE leads more easily to memory corruption than on other platforms, which mostly depends on the memory layout (i.e. linker script) for a specific platform.

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 21, 2018

The stack size we are talking here is only for the threads created specifically in these netsocket tcp cases. Doesn't have systemwide affect.

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 26, 2018

@betzw have you had time yet to check this?

@betzw

This comment has been minimized.

Contributor

betzw commented Sep 26, 2018

Not yet.

@betzw

This comment has been minimized.

Contributor

betzw commented Sep 26, 2018

netsocket-tcp test run on my side also with 2K of stack.

@VeijoPesonen

This comment has been minimized.

Contributor

VeijoPesonen commented Sep 27, 2018

@betzw @SeppoTakalo @cmonr please review and and once it's done - needs: CI

Increases stack size for threads used in gt netsocket tcp test cases
Stack size is insufficient for debug profile
Stack size is insufficient for NUCLEO_F401RE+IDW01M1
Please see ARMmbed/wifi-x-nucleo-idw01m1#17

@VeijoPesonen VeijoPesonen force-pushed the VeijoPesonen:bugfix-tests-netsocket-tcp-stacksize branch from 7dae21e to c454691 Sep 27, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 27, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3179
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8132/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

cmonr approved these changes Sep 27, 2018

@cmonr cmonr merged commit b1b6399 into ARMmbed:master Sep 27, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 625 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9144 cycles (-739 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Sep 27, 2018

@VeijoPesonen VeijoPesonen deleted the VeijoPesonen:bugfix-tests-netsocket-tcp-stacksize branch Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment