New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication on a cellular network for Access Point Name (APN) #8147

Merged
merged 3 commits into from Sep 22, 2018

Conversation

Projects
None yet
5 participants
@AriParkkila
Contributor

AriParkkila commented Sep 17, 2018

Description

Fix authentication on a cellular network for Access Point Name (APN).

Changes as per a commit:

  • APN authentication only on inactive context (Arm internal ref IOTCELL-1351)
  • Use proprietary commands for APN authentication on BG96
  • APN authentication currently not supported on HE910 and BC95

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Sep 17, 2018

@AriParkkila AriParkkila changed the title from Cell auth to Fix authentication on a cellular network for Access Point Name (APN) Sep 17, 2018

@@ -197,6 +197,10 @@ void AT_CellularNetwork::urc_cgreg()
nsapi_error_t AT_CellularNetwork::set_credentials(const char *apn,
const char *username, const char *password)
{
if (!is_supported(AT_CGAUTH)) {

This comment has been minimized.

@jarvte

jarvte Sep 17, 2018

Contributor

Should there be check that if only apn is set then it does not matter if authentication is supported?

This comment has been minimized.

@AriParkkila

AriParkkila Sep 17, 2018

Contributor

Good point due to APN can be given without username/password. See fixed.

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-auth branch from 17b2797 to 13106fb Sep 17, 2018

@jarvte

jarvte approved these changes Sep 17, 2018

@cmonr

cmonr approved these changes Sep 20, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 21, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 21, 2018

Build : SUCCESS

Build number : 3119
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8147/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 21, 2018

I wish I could say that the PR needs work...

/morph test

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 73a96a6 into ARMmbed:master Sep 22, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10261 cycles (+853 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment