New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usticker feature to TMPM066 #8149

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
6 participants
@ganesh-ramachandran
Contributor

ganesh-ramachandran commented Sep 17, 2018

Description

Add usticker feature to TMPM066

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change
@0xc0170

Tested with all 3 toolchains ? How this is fixing us ticker - it was disabled - so reenabling with reworking the us ticker to use different peripheral ticker ?

}
void us_ticker_clear_interrupt(void)
{
//no flags to clear
INTIFSD_ClearINTReq(INTIFSD_INT_SRC_TMRB_7_MDOVF);
NVIC_ClearPendingIRQ(INTTB7_IRQn);
}
void us_ticker_free(void)
{

This comment has been minimized.

@0xc0170

0xc0170 Sep 18, 2018

Member

should this function still be empty?

This comment has been minimized.

@ganesh-ramachandran

ganesh-ramachandran Sep 18, 2018

Contributor

Used only function body for compilation success. However implemented the function now.

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Sep 18, 2018

Tested with all 3 toolchains ? How this is fixing us ticker - it was disabled - so reenabling with reworking the us ticker to use different peripheral ticker ?

Yes, tested with all 3 toolchains.
To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
That is why we have changed the peripheral ticker A to B.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 18, 2018

To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
That is why we have changed the peripheral ticker A to B.

This is good info to have (exactly what I was asking), can you add it to the commit message?

Ganesh Ramachandran added some commits Sep 17, 2018

Ganesh Ramachandran Ganesh Ramachandran
Added usticker feature
To enable the feature US_TICKER, file is newly implemented with Timer B, which has proper clock prescale and free running after match interrupt.
Old us_ticker driver file (Timer A) is producing up to 100us tolerance, which causes to fail US_TICKER feature.
Hence, changed the peripheral ticker A to B.
Ganesh Ramachandran Ganesh Ramachandran
@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Sep 19, 2018

This is good info to have (exactly what I was asking), can you add it to the commit message?

Added to commit message and Rebased.

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-hal Sep 19, 2018

@jamesbeyond

This comment has been minimized.

Contributor

jamesbeyond commented Sep 19, 2018

Hi @ganesh-ramachandran,
Due to our CI will not cover your target, could you attach the test log as a proof of implementation correctness?
mbed test -t <toolchain> -m TMPM066 -n tests-mbed_hal-common_ticker*,tests-mbed_hal-us_ticker*
more info about usticker tests can be found at HERE if required

@ganesh-ramachandran

This comment has been minimized.

Contributor

ganesh-ramachandran commented Sep 19, 2018

Due to our CI will not cover your target, could you attach the test log as a proof of implementation correctness?

Hi @jamesbeyond, Please find below the ticker test log.
M066_ARM_TestResults.txt
M066_GCC_ARM_TestResults.txt
M066_IAR_TestResults.txt

@jamesbeyond

Looks good

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3257
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8149/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 866018b into ARMmbed:master Oct 8, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 605 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10240 cycles (+961 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

@ganesh-ramachandran ganesh-ramachandran deleted the ganesh-ramachandran:m066_usticker-new_feature branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment