New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: automatic unit test suite naming #8153

Merged
merged 3 commits into from Sep 20, 2018

Conversation

Projects
None yet
6 participants
@lorjala
Contributor

lorjala commented Sep 17, 2018

Description

Use unit test suite names automatically derived from the file path.

  • File paths are unique so test suite names are unique.
  • Same naming convention as previously.
  • No effect on existing tests.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 17, 2018

@0xc0170 0xc0170 requested review from OPpuolitaival and SeppoTakalo Sep 17, 2018

@OPpuolitaival

Looks good

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 19, 2018

sigh

This needs a rebase. We'll start CI immediately after.

@cmonr cmonr added needs: work and removed needs: CI labels Sep 19, 2018

@lorjala lorjala force-pushed the lorjala:unittests-autoname branch from 9861a38 to 8f340b1 Sep 19, 2018

@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 19, 2018

@0xc0170 @cmonr trigger build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Sep 19, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2018

@0xc0170 @cmonr trigger build

Waiting for 2 jobs to finish, will be triggered

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 19, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3111
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8153/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Sep 20, 2018

@0xc0170 0xc0170 merged commit 6c34802 into ARMmbed:master Sep 20, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 605 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10039 cycles (+760 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@lorjala lorjala deleted the lorjala:unittests-autoname branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment