New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform timer: Call timer start in enable #8210

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
7 participants
@JarkkoPaso
Contributor

JarkkoPaso commented Sep 21, 2018

This timer was never started and therefore read_us returned always 0 causing bad timings.

Description

This timer was never started and therefore read_us returned always 0 causing bad timings.

Tested with K64F and Nucleo-F429ZI

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Sep 21, 2018

@@ -47,6 +47,7 @@ void platform_timer_enable(void)
#endif
// Prime the SingletonPtrs - can't construct from IRQ/critical section
timer.get();
timer->start();

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Sep 21, 2018

Contributor

Um. Seriously? I guess no-one was ever relying on this in the absence of frequency-hopping?

Yikes.

Anyway, if you're doing timer->start(), don't need the "dummy" timer.get(), so remove that line.

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Sep 21, 2018

Contributor

Oh, and maybe put the "prime" comment above just the remaining timeout.get, as it's about that dummy get. timer->start() is inherently obvious.

But apparently not obvious enough for me to put in the code in the first place. Sigh.

This comment has been minimized.

@JarkkoPaso

JarkkoPaso Sep 21, 2018

Contributor

@kjbracey-arm I guess, even without frequency hopping it caused some issues with MAC timer. Too short Ack wait durations caused MAC retransmissions etc. Please check the changes I made.

platform timer: Call timer start in enable
This timer was never started and therefore read_us returned always 0 causing bad timings.

@JarkkoPaso JarkkoPaso force-pushed the JarkkoPaso:master branch from def4c2f to a3ec9f3 Sep 21, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 21, 2018

@TuomoHautamaki

This comment has been minimized.

TuomoHautamaki commented Oct 2, 2018

@0xc0170 can you please initialise CI for this PR.

Thanks,
Tuomo

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

I can build it soon (there are two jobs in the queue now) but exporters are having an issue currently, we are investigating.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

/morph build

@cmonr

cmonr approved these changes Oct 8, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3280
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8210/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 9c28794 into ARMmbed:master Oct 9, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
jenkins-ci/unittests Test job: successful
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10262 cycles (+33 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment