New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix RTC base time (#8214) #8230

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
9 participants
@mprse
Member

mprse commented Sep 24, 2018

Description

Change the base time value to more realistic:
START_TIME = 1537789823 # GMT: Monday, 24 September 2018 11:50:23

This fix has been proposed by STM in order to enhance test efficiency.
Current test version did not detect problem with RTC reset on STM F1 family boards, since the base time was too small.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Fix for issue #8214
Change the base time value to more realistic:
START_TIME = 1537789823 # GMT: Monday, 24 September 2018 11:50:23

This fix has been proposed by STM in order to enhance test efficiency.
Current test version did not detect problem with RTC reset on F1 family boards since the base time was too small.

@mprse mprse referenced this pull request Sep 24, 2018

Open

Improve rtc_reset test ? #8214

@0xc0170 0xc0170 requested review from c1728p9 and ARMmbed/team-st-mcd Sep 24, 2018

@bcostm

bcostm approved these changes Sep 24, 2018

@bcostm

This comment has been minimized.

Contributor

bcostm commented Sep 24, 2018

I ran the rtc tests on the NUCLEO_F103RB platform and now the rtc_reset test is well FAIL as planned :)

+-------------------+---------------+------------------------------+--------+--------------------+-------------+
| target            | platform_name | test suite                   | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+------------------------------+--------+--------------------+-------------+
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_drivers-rtc       | OK     | 30.73              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc           | OK     | 50.62              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_reset     | FAIL   | 21.15              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_time      | OK     | 17.29              | default     |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-mbed_hal-rtc_time_conv | OK     | 38.0               | default     |
+-------------------+---------------+------------------------------+--------+--------------------+-------------+
@c1728p9

c1728p9 approved these changes Oct 3, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 4, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3260
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8230/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 7, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@mprse

This comment has been minimized.

Member

mprse commented Oct 8, 2018

only tests-mbed_hal-flash test has failed on EV_COG_AD3029LZ / ARM. This looks not related.

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 12, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 8bf51be into ARMmbed:master Oct 13, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9118 cycles (+66 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 13, 2018

@0xc0170 0xc0170 changed the title from Fix for issue #8214 to Fix RTC base time (#8214 Oct 24, 2018

@0xc0170 0xc0170 changed the title from Fix RTC base time (#8214 to test: fix RTC base time (#8214) Oct 24, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment