New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix component coding style #8244

Merged
merged 1 commit into from Oct 25, 2018

Conversation

Projects
None yet
5 participants
@0xc0170
Member

0xc0170 commented Sep 25, 2018

Description

Components astyle update

The only exception I made was inlined assembly in rf driver (skipped from astyle).

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested review from SeppoTakalo and ARMmbed/mbed-os-storage Sep 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 25, 2018

Are these components still maintained outside this repository (should this be addressed there first) ?

@yossi2le

This comment has been minimized.

Contributor

yossi2le commented Sep 25, 2018

Are these components still maintained outside this repository (should this be addressed there first)?

I can only answer about the storage components. I believe that besides bug fixes affecting 5.9 or earlier versions, no new functionality will be added to the external repo. So I think it's not a must to Astyle the external repos.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Sep 25, 2018

RF and WiFi drivers are still developed outside of Mbed OS tree for faster review&test cycle.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 25, 2018

RF and WiFi drivers are still developed outside of Mbed OS tree for faster review&test cycle.

How can we move this there so they match ? I can send PR to those (same astyle command run), would that help?

@yossi2le

Looks like great Astyling for me:)
10x.

@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 4, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

@0xc0170 Needs work?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 23, 2018

I am on it within a day. If not, I'll close this PR and reopen once I sync all repos with the styling changes.

@0xc0170 0xc0170 force-pushed the 0xc0170:fix_components_astyle branch from 17c4766 to 53f1397 Oct 25, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

I scoped down this to storage component only. Same commit, so latest review should stand and this should be ready for CI

@SeppoTakalo As wifi and rc components are outside of this tree, can anyone from your team do style clean-up in the repos and send an update to Mbed OS?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 25, 2018

@0xc0170 0xc0170 changed the title from Fix components astyle to storage: fix component coding style Oct 25, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 25, 2018

Build : SUCCESS

Build number : 3459
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8244/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

@ARMmbed/mbed-os-maintainers your review needed here

@cmonr

cmonr approved these changes Oct 25, 2018

@cmonr cmonr merged commit 395ea06 into ARMmbed:master Oct 25, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 665 files (-12 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10203 cycles (-49 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 25, 2018

@0xc0170 0xc0170 deleted the 0xc0170:fix_components_astyle branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment