New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools, Resources: Convert to a set during win2unix #8248

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Sep 25, 2018

Description

The exporters were failing as some things would end up as a list after
win2unix. Resolves #7954

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr cmonr added the needs: review label Sep 26, 2018

@cmonr cmonr requested review from bridadan and cmonr Sep 26, 2018

@bridadan

One line change 🎉 Looks good

@cmonr cmonr added needs: CI and removed needs: review labels Sep 26, 2018

@cmonr

cmonr approved these changes Sep 26, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 11, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 11, 2018

Build : SUCCESS

Build number : 3321
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8248/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 11, 2018

All licensing tokens for the specified feature are already in use. Status code 0xc8001006. [LicenseCheck:2.15.2.J2938, RMS:8.5.1.2009, Feature:ARM.EW.COMPILER, Version:1.10]

booo

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 11, 2018

@cmonr cmonr merged commit 19190d6 into ARMmbed:master Oct 11, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9926 cycles (+725 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment