New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-coap to version 4.7.0 #8273

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
7 participants
@anttiylitokola
Contributor

anttiylitokola commented Sep 27, 2018

Description

  • Add function that can be used to clear the received blockwise payloads for example in the case of a connection error.
  • Silence compiler warning when CoAP duplicate detection is enabled.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Update mbed-coap to version 4.7.0
- Add function that can be used to clear the received blockwise payloads for example in the case of a connection error.
- Silence compiler warning when CoAP duplicate detection is enabled.

@anttiylitokola anttiylitokola force-pushed the anttiylitokola:mbed-coap-4.7.0 branch from 317192b to 4c692c6 Sep 27, 2018

@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Sep 27, 2018

@yogpan01, please review.

@cmonr cmonr requested a review from yogpan01 Sep 27, 2018

@cmonr cmonr added the needs: review label Sep 27, 2018

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Sep 27, 2018

Approved. This is needed for client to handle memory gracefully when it is recovering from connection break while in the middle of firmware download.

@0xc0170

0xc0170 approved these changes Oct 1, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 1, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 2, 2018

Build : SUCCESS

Build number : 3215
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8273/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

/morph test

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

/morph test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

@ChiefBureaucraticOfficer Could you take a look at this?

A new function was added, but it appears that this might be needed in a patch release for cloud client (correct @yogpan01?).

@ChiefBureaucraticOfficer

This comment has been minimized.

ChiefBureaucraticOfficer commented Oct 8, 2018

@ChiefBureaucraticOfficer Could you take a look at this?

A new function was added, but it appears that this might be needed in a patch release for cloud client (correct @yogpan01?).

Please clarify - has the owner of COAP reviewed these changes? The changes are optional, no adoption is required by existing users? No other known behaviors are altered?

If the answers to all of the above are 'yes', then the process excursion is APPROVED for the PR.

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Oct 10, 2018

@0xc0170 @ChiefBureaucraticOfficer
CoAP changes are feature enhancement and are completely optional. Existing users of CoAP may or may not use it and it will not impact to any existing functionality of CoAP library.
Since, its a complete new API there is no changed behaviour in any of the existing source code or APIs.

@cmonr cmonr added ready for merge and removed needs: review labels Oct 10, 2018

@cmonr cmonr merged commit 2c296fc into ARMmbed:master Oct 11, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9169 cycles (-1046 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment