New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export, nb: Use same path for cpp as the rest of the tools #8274

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Sep 27, 2018

Description

The netbeans exporter was being inconsistant with it's invocation of
the C pre-processor on the linker script: the C pre-processor was always
invoked from $PATH where as the rest of the tools were invoked as
configured by the tools. This changes the invocation of CPP to match the
rest of the tools: heed the conifguration.

Fixes ARMmbed/mbed-cli#663

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Export, nb: Use same path for cpp as the rest of the tools
### Description

The netbeans exporter was being inconsistant with it's invocation of
the C pre-processor on the linker script: the C pre-processor was always
invoked from `$PATH` where as the rest of the tools were invoked as
configured by the tools. This changes the invocation of CPP to match the
rest of the tools: heed the conifguration.

Fixes ARMmbed/mbed-cli#663

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change
@cmonr

cmonr approved these changes Sep 27, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Oct 12, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 12, 2018

Build : SUCCESS

Build number : 3337
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8274/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr cmonr merged commit 4aef073 into ARMmbed:master Oct 12, 2018

13 of 15 checks passed

ci-morph-exporter build in progress
Details
ci-morph-test test in progress
Details
ci-morph-build build completed
Details
ci-morph-mbed2-build build completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9121 cycles (-1094 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 12, 2018

Build results can be found in the rolled-up PR: #8387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment