New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Raise NotSupported when target definition is incomplete #8288

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Oct 1, 2018

Description

Noticed by the online compiler:
When a user has an incomplete target definition, the error is not show
to the user. That's because it's reported as a KeyError. This PR adds
an outer NotSupportedException so that the outer catch statement knows
that this is not a build system crash, but a user error.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@0xc0170

0xc0170 approved these changes Oct 1, 2018

@cmonr

cmonr approved these changes Oct 12, 2018

@cmonr cmonr added rollup PR and removed rollup PR labels Oct 13, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 14, 2018

@theotherjimmy , this probably needs a minor rebase

tools: Raise NotSupported when target definition is incomplete
### Description

Noticed by the online compiler:
When a user has an incomplete target definition, the error is not show
to the user. That's because it's reported as a `KeyError`. This PR adds
an outer `NotSupportedException` so that the outer catch statement knows
that this is not a build system crash, but a user error.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:incomplete-targets-notsupported branch from 5b17c81 to 9c3307a Oct 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 17, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Oct 17, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2018

Build : SUCCESS

Build number : 3394
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8288/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit a0a3dd6 into ARMmbed:master Oct 18, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+36 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 670 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9098 cycles (-1125 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment