New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset channel settings back to default #8298

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
7 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Oct 2, 2018

Description

Reset channel settings back to default after changing channels in WiFi test.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Oct 2, 2018

@asifrizwanubx

Seems fine.

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 2, 2018

@0xc0170 Please run the tests.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

The only test we can run is build, test + exporters will fail due to reported issues

@AmmadRehmat

This comment has been minimized.

Contributor

AmmadRehmat commented Oct 4, 2018

Is it due to any reported issues in this fix or some other fix?

The only test we can run is build, test + exporters will fail due to reported issues

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

@AmmadRehmat #8297 - exporters currently. Tests should be fine.

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 4, 2018

@0xc0170

0xc0170 approved these changes Oct 4, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 4, 2018

Build : SUCCESS

Build number : 3235
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8298/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 5a47318 into ARMmbed:master Oct 10, 2018

16 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Success
Details
jenkins-ci/greentea-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10245 cycles (-26 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment