New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use wait_ms(int) instead of wait(float) #8302

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@JanneKiiskila
Contributor

JanneKiiskila commented Oct 2, 2018

Small space savings, the casting from int to float will bloat
the code a bit. Using wait(1.0f) for example would avoid it,
but seems a bit silly to use floats for anything unless
really needed (in embedded products).

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@JanneKiiskila JanneKiiskila changed the title from Use wait_ms instead of wait(n) to Use wait_ms(int) instead of wait(float) Oct 3, 2018

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Oct 3, 2018

@0xc0170 0xc0170 requested review from ARMmbed/mbed-os-core and removed request for ARMmbed/mbed-os-core Oct 4, 2018

@0xc0170

0xc0170 approved these changes Oct 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2018

Ready for CI , can you rebase to resolve the conflict please?

Use wait_ms instead of wait(n)
Small space savings, the casting from int to float will bloat
the code a bit. Using wait(1.0f) for example would avoid it,
but seems a bit silly to use floats for anything unless
really needed (in embedded products).

@JanneKiiskila JanneKiiskila force-pushed the JanneKiiskila:wait_ms branch from 1d98a67 to de77695 Oct 16, 2018

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented Oct 16, 2018

Rebased, git resolved it with a 3-way merge automatically.

@cmonr cmonr added needs: CI and removed needs: work labels Oct 16, 2018

@cmonr

cmonr approved these changes Oct 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3379
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8302/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 17, 2018

@cmonr cmonr merged commit 2daab38 into ARMmbed:master Oct 17, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 666 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9134 cycles (-6 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment