New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Use logical paths in ignored_dirs #8303

Merged
merged 4 commits into from Oct 19, 2018

Conversation

Projects
None yet
6 participants
@theotherjimmy
Contributor

theotherjimmy commented Oct 2, 2018

Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

Resolves #7155
Tested on partnerbeta.
Includes minor formatting fixes that I found at the time as seperate
commits.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

theotherjimmy added some commits Oct 2, 2018

Tools: Use logical paths in ignored_dirs
### Description

Exporting to GNU ARM Eclipse, E2 Studio, and other exclude-based IDEs
currently generats unusable project files online. This is because the
list of directories ignored in the scan is inconsistant about what sort
of paths are used: logical paths, or phisical paths. This patch makes
all paths in ignored_dirs logical. This should fix the excluding tags
in these project files.

### Pull request type

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Breaking change

@cmonr cmonr requested a review from TomoYamanaka Oct 8, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Oct 9, 2018

@0xc0170

0xc0170 approved these changes Oct 9, 2018

@cmonr

cmonr approved these changes Oct 9, 2018

@cmonr cmonr added needs: CI and removed needs: review labels Oct 9, 2018

@TomoYamanaka

LGTM.
We will make a final confirmation when this PR merged on Arm Mbed Online environment because we don't know the verifying method at this time.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 10, 2018

This is such a strange flow.

This change doens't seem to be cooperating with a certain set of targets. Refer to these build logs: #8357 (comment)

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/moprh build

@cmonr cmonr added needs: CI and removed needs: work labels Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

/moprh build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 19, 2018

Should be fixed now @cmonr

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 19, 2018

Yay! Time to warm up the lab.
/morph build

@cmonr cmonr added needs: CI and removed needs: work labels Oct 19, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 19, 2018

Build : SUCCESS

Build number : 3406
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8303/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit c004aa8 into ARMmbed:master Oct 19, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 672 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10202 cycles (+465 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment