New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RapidIoT #8307

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
8 participants
@mmahadevan108
Contributor

mmahadevan108 commented Oct 2, 2018

Description

This PR requires

  1. Update to greentea ARMmbed/greentea#282
  2. Update to mbed-ls ARMmbed/mbed-ls#393
  3. Update to DAPLink ARMmbed/DAPLink#508

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change
@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Oct 2, 2018

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add-Support_RapidIoT branch 2 times, most recently from 0b2cc58 to 6e86296 Oct 3, 2018

@0xc0170 0xc0170 requested review from maclobdell and ashok-rao Oct 4, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Oct 4, 2018

@0xc0170

0xc0170 approved these changes Oct 5, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2018

Update to greentea ARMmbed/greentea#282
Update to mbed-ls ARMmbed/mbed-ls#393
Update to DAPLink ARMmbed/DAPLink#508

needs: preceding PR

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

Interesting.

@ARMmbed/mbed-os-test
This should only require PR updates, correct? No changes/updatess to CI needed?

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 8, 2018

@cmonr as the board is not part of HW test, no need to update tools.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2018

@maclobdell @ashok-rao Please review

I2C_SCL = PTC10,
I2C_SDA = PTC11,

This comment has been minimized.

@ashok-rao

ashok-rao Oct 10, 2018

Contributor

@mmahadevan108 : No SPI brought out?

This comment has been minimized.

@mmahadevan108

mmahadevan108 Oct 16, 2018

Contributor

I have added SPI defines in the PinNames.h file.

"macros": ["FSL_RTOS_MBED", "USE_EXTERNAL_RTC"],
"default_toolchain": "ARM",
"default_lib": "std",
"release_versions": ["2", "5"]

This comment has been minimized.

@ashok-rao

ashok-rao Oct 10, 2018

Contributor

@mmahadevan108 : you may want to add a "public: false" here for the parent target..

This comment has been minimized.

@mmahadevan108

mmahadevan108 Oct 16, 2018

Contributor

Thank you. I have made this change and updated the PR.

"macros_add": ["CPU_MK64FN1M0VMD12", "TARGET_K64F"],
"is_disk_virtual": true,
"mbed_rom_start": "0x00014000",
"mbed_rom_size": "0xEC000",

This comment has been minimized.

@ashok-rao

ashok-rao Oct 10, 2018

Contributor

@0xc0170, @mmahadevan108 / @maclobdell : Would it be better to move these 2 (ram,rom starts) to the respective linker descriptions (ARMCC / GCC / IAR) rather than here? wrapped in an #ifdef for the rapidiot targets only..

This comment has been minimized.

@0xc0170

0xc0170 Oct 10, 2018

Member

https://github.com/ARMmbed/mbed-os/blob/master/tools/config/__init__.py#L628 - cant find the documentation so the code reference.

@ashok-rao

Thanks @mmahadevan108 . Some minor comments added. Otherwise looking good!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2018

@mmahadevan108 Can you review latest comments? This addition is almost ready for CI

maclobdell and others added some commits Aug 3, 2018

Add support for NXP Rapid IoT prototyping kit
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
MCUXpresso Flash Driver: Update Flash driver to support RAPIDIOT
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:Add-Support_RapidIoT branch from 6e86296 to 9a47915 Oct 16, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Oct 16, 2018

@ashok-rao @0xc0170 I have updated the PR with changes to include comments received.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 16, 2018

@ashok-rao @maclobdell Could y'all take another look? Ignore the unittest result, as it's not this PR's fault.

@cmonr cmonr added needs: review and removed needs: work labels Oct 16, 2018

SPI_MOSI = PTC6,
SPI_MISO = PTC7,
SPI_SCK = PTC5,
SPI_PERSISTENT_MEM_CS = PTC4,

This comment has been minimized.

@ashok-rao

ashok-rao Oct 17, 2018

Contributor

@mmahadevan108 : Not sure if this pin name for the CS maintains consistency with others? why not SPI_SSEL or SPI_NCS ..?
cc @0xc0170 @cmonr ..

This comment has been minimized.

@mmahadevan108

mmahadevan108 Oct 17, 2018

Contributor

I am not familiar with the names, I copied this from K64F. These are new additions and I am not familiar with the use-case for which these were added, please suggest and I will make the change.

This comment has been minimized.

@0xc0170

0xc0170 Oct 17, 2018

Member

@yossi2le Can you review this one?

@ashok-rao

Just a minor comment added on naming convention.. rest all LGTM! Thanks @mmahadevan108 ..

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3392
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8307/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit c9adf3c into ARMmbed:master Oct 18, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+36 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 666 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9086 cycles (-54 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 18, 2018

@mmahadevan108 mmahadevan108 deleted the NXPmicro:Add-Support_RapidIoT branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment