New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cellular unittests #8315

Merged
merged 2 commits into from Oct 8, 2018

Conversation

Projects
None yet
7 participants
@kivaisan
Contributor

kivaisan commented Oct 3, 2018

Description

Fix cellular UT instability. CellularSocket class did not have constructor and therefore it's members were not initialized.

Also fixed some build warnings and style issues.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

kivaisan added some commits Oct 3, 2018

Cellular: Fix AT_CellularStack unittest
Missing CellularSocket constructor caused uninitialized values to be used.

Also changed comparision macros to ASSERT_EQ as suggested by GoogleTest guide.
@kivaisan

This comment has been minimized.

Contributor

kivaisan commented Oct 3, 2018

@jarvte

jarvte approved these changes Oct 4, 2018

char table[] = "1.2.3.4.5.65.7.8.9.10.11\0";
ATHandler_stub::ssize_value = -1;
ATHandler_stub::bool_value = true;
ATHandler_stub::read_string_value = table;
EXPECT_TRUE(NULL == st.get_ip_address());
EXPECT_TRUE(st.get_ip_address() == NULL);

This comment has been minimized.

@mirelachirica

mirelachirica Oct 4, 2018

Contributor

Didi you mean EXPECT_EQ(st.get_ip_address(), NULL); ?

This comment has been minimized.

@kivaisan

kivaisan Oct 4, 2018

Contributor

NULL is an exception. GTest does not allow comparision to NULL with EXPECT_EQ.

This comment has been minimized.

@mirelachirica

mirelachirica Oct 4, 2018

Contributor

Is the change of the operands order relevant to how the fail is reported or just a code style issue?

This comment has been minimized.

@kivaisan

kivaisan Oct 4, 2018

Contributor

Just a code style to follow other EXCEPT checks.

According to Google Test documentation:

However, when possible, ASSERT_EQ(actual, expected) is preferred to ASSERT_TRUE(actual == expected), since it tells you actual and expected's values on failure.

So I just used the same format for all.

@0xc0170

0xc0170 approved these changes Oct 4, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 6, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3258
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8315/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit b15d091 into ARMmbed:master Oct 8, 2018

17 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/mbed-os-ci-compile-ARM Success
Details
jenkins-ci/mbed-os-ci-compile-IAR Success
Details
jenkins-ci/mbed-os-compile-GCC_ARM Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10247 cycles (+35 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment