New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests: Add tests for netsocket classes #8316

Merged
merged 1 commit into from Oct 10, 2018

Conversation

Projects
None yet
5 participants
@michalpasztamobica
Contributor

michalpasztamobica commented Oct 3, 2018

New classes covered with unit tests are: SocketAddress, EthernetInterface, EMACInterface,

Description

WiFiAccessPoint.
Also added missing namespace in front of mbed::Callback usages.
EMACInterface is covered by the EthernetInterface unit tests.

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@michalpasztamobica

This comment has been minimized.

Contributor

michalpasztamobica commented Oct 3, 2018

@SeppoTakalo please review

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 3, 2018

@0xc0170 Can you restart the travis check? Seems to have failed on connection error.

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:master branch from c83a919 to bec7b8b Oct 4, 2018

@michalpasztamobica

This comment has been minimized.

Contributor

michalpasztamobica commented Oct 4, 2018

The CI build is failing due to an incorrect command when pip is installing astyle package. I can see that other builds also failed.
This command
tar xf astyle.tar.gz will fail to extract the gzipped file because the "z" option is missing.
tar xzf astyle.tar.gz should work better.
@0xc0170 @SeppoTakalo, do you agree? Is this a bug within pip or can this be fixed on Travis side?

@michalpasztamobica

This comment has been minimized.

Contributor

michalpasztamobica commented Oct 4, 2018

Sorry, I checked that tar xf astyle_3.1_linux.tar.gz actually works fine on my machine. It must be a corrupted tar.gz file, then...

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

@0xc0170 Can you restart the travis check? Seems to have failed on connection error.

Restarted. Please use @ARMmbed/mbed-os-maintainers , anyone from the team should be able to help here

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

Sorry, I checked that tar xf astyle_3.1_linux.tar.gz actually works fine on my machine. It must be a corrupted tar.gz file, then...

It's been working for some months.. I suspect something is wrong with s3. Package has not been updated to my knowledge. I am creating a new issue to fix this

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

Created tracking issue for it #8322 . The archive on s3 seems to be corrupted

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 4, 2018

Created tracking issue for it #8322 . The archive on s3 seems to be corrupted

Fixed

@0xc0170 0xc0170 changed the title from unittests: Added tests for netsocket classes to unittests: Add tests for netsocket classes Oct 4, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-maintainers Oct 4, 2018

@0xc0170

0xc0170 approved these changes Oct 5, 2018

@0xc0170

Please review astyle (requesting changes)

@0xc0170 0xc0170 added needs: work and removed needs: review labels Oct 5, 2018

unittests: Added tests for netsocket classes
New classes covered with unit tests: SocketAddress, EthernetInterface, EMACInterface, WiFiAccessPoint.
Also added missing namespace in front of mbed::Callback usages.
EMACInterface is covered by the EthernetInterface unit tests.

@michalpasztamobica michalpasztamobica force-pushed the michalpasztamobica:master branch from bec7b8b to 5b4634a Oct 8, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

@0xc0170 Mind re-reviewing?

@cmonr cmonr added needs: review and removed needs: work labels Oct 8, 2018

@0xc0170

0xc0170 approved these changes Oct 9, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 10, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 10, 2018

Build : SUCCESS

Build number : 3308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8316/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 10, 2018

@cmonr cmonr merged commit 21b4eca into ARMmbed:master Oct 10, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 649 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9715 cycles (+506 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment