New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard Atmel RF driver build by DEVICE_I2C #8327

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
6 participants
@SeppoTakalo
Contributor

SeppoTakalo commented Oct 4, 2018

Description

This module uses AT24MAC chip which is in I2C bus, so it requires
device to support I2C

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@0xc0170

0xc0170 approved these changes Oct 4, 2018

@0xc0170 0xc0170 added the needs: CI label Oct 4, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-ipcore Oct 4, 2018

@@ -15,6 +15,9 @@
*/
#include "at24mac.h"
// This driver required I2C

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Oct 4, 2018

Contributor

Don't think this comment is adding anything - if you want it, it's "requires".

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 7, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 7, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 8, 2018

[DEBUG] Output: Unable to connect to the license server. Check that ARMLMD_LICENSE_FILE is set correctly, and the license server is available.
[DEBUG] Output: Information about this error is available at: http://ds.arm.com/support/lic56/m97
[DEBUG] Output:  General licensing information is available at: http://ds.arm.com/support/licensing/
[DEBUG] Output:  If you need further help, provide this complete error report to your supplier or license.support@arm.com.

Please restart the CI

Guard Atmel RF driver build by DEVICE_I2C
This module uses AT24MAC chip which is in I2C bus, so it requires
device to support I2C

@SeppoTakalo SeppoTakalo force-pushed the SeppoTakalo:i2c_guard branch from 16c51d1 to f16a99c Oct 8, 2018

@SeppoTakalo

This comment has been minimized.

Contributor

SeppoTakalo commented Oct 8, 2018

Extra comment removed as Kevin suggested.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Build number : 3294
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8327/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 9, 2018

failure in mbed2-build is IAR license related - rerunning
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 06dffda into ARMmbed:master Oct 9, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 652 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9078 cycles (-1119 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment