New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K66F default sd storage #8348

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
7 participants
@maclobdell
Contributor

maclobdell commented Oct 9, 2018

Description

K66F has an SD Card. Let's implement it as the default storage using the new default storage mechanism in 5.10. This helps ensure new example apps that use BlockDevice::get_default_instance(); work with no extra configuring.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Breaking change

@maclobdell maclobdell requested a review from mmahadevan108 Oct 9, 2018

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Oct 9, 2018

Will this be using the SD card available via the Arduino connector (e.g ci-test shield)?

@0xc0170

0xc0170 approved these changes Oct 9, 2018

@maclobdell

This comment has been minimized.

Contributor

maclobdell commented Oct 11, 2018

@mmahadevan108 the K66F has an on-board micro SD card connector. so arduino shield is not necessary.

@geky geky requested review from dannybenor, yossi2le and ARMmbed/mbed-os-storage Oct 11, 2018

Show resolved Hide resolved targets/targets.json Outdated
@maclobdell

This comment has been minimized.

Contributor

maclobdell commented Oct 17, 2018

I updated the branch to remove the Feature: Storage, so the CFStore will not be added with this PR.

@yossi2le

LGTM

@cmonr

cmonr approved these changes Oct 19, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 21, 2018

Build : SUCCESS

Build number : 3418
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8348/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 353e8bd into ARMmbed:master Oct 22, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 667 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9842 cycles (-109 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment