New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renesas : Improve ARMCC linker script #8374

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
6 participants
@TomoYamanaka
Contributor

TomoYamanaka commented Oct 11, 2018

Description

To address issue #6975 , I remove inclusion processing and define the related macros at ARMCC linker script file.

For Arm toolchain build, Mbed 2(classic) programs occur an unexpected error if there is #include "mem_XXXX.h" in the script file. It seems that the linker script can't find the include file because mem_XXXX.h file is not in the same path with the linker script.

There is no problem with Mbed OS 5 programs.

@mbedNoobNinja
Could you review about changes to VK_RZ_A1H?

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
Improve ARMCC linker script for Renesas boards
For Arm toolchain build, Mbed 2(classic) programs occur an unexpected error if there is "#include "mem_XXXX.h"" in the script file.
It seems that the linker script can't find the include file because "mem_XXXX.h" file is not in the same path with the linker script.
(Refer to Issue #6975.)
To address this issue, I remove inclusion processing and define the related macros at ARMCC linker script file.

@cmonr cmonr requested review from ARMmbed/mbed-os-tools Oct 11, 2018

@cmonr cmonr added the needs: review label Oct 11, 2018

@cmonr

cmonr approved these changes Oct 15, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 15, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Oct 15, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 15, 2018

Build : SUCCESS

Build number : 3362
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8374/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit deaa4fa into ARMmbed:master Oct 16, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 655 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10382 cycles (+1254 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 16, 2018

@TomoYamanaka TomoYamanaka deleted the TomoYamanaka:improve_armcc_linkerscript branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment