New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: fix issue with serial_is_tx_ongoing function #8403

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
6 participants
@bcostm
Contributor

bcostm commented Oct 12, 2018

Description

When DEVICE_SERIAL is not defined there is a build error with the serial_is_tx_ongoing function not defined.

Fixes #8372

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Oct 12, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 16, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 16, 2018

IAR license related failure: re-running
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 16, 2018

Build : SUCCESS

Build number : 3369
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8403/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 16, 2018

@cmonr cmonr merged commit 5c136cc into ARMmbed:master Oct 16, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 658 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9855 cycles (-83 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 16, 2018

@bcostm bcostm deleted the bcostm:fix_issue_8372_serial branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment