New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block device general tests #8430

Merged
merged 7 commits into from Oct 23, 2018

Conversation

Projects
None yet
8 participants
@theamirocohen
Contributor

theamirocohen commented Oct 15, 2018

Suite of tests that can be easily configured to use a custom block device

@theamirocohen

This comment has been minimized.

Contributor

theamirocohen commented Oct 15, 2018

@yossi2le @offirko
I'll be happy for your review

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-storage Oct 15, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 15, 2018

[x] Target update

It does not look like a target update but rather docs update and also adding tests

1. [Hardware requirements](#hardware-requirements)
2. [Usage](#usage)
- [Compile the test](#compile-the-test)
- [Run the test](#run-the-test)

This comment has been minimized.

@offirko

offirko Oct 16, 2018

Contributor

Link doesnt work (I think text and link should be "run the example")


## Changing the block device

In Mbed OS, a C++ classes that inherits from the [BlockDevice](https://os.mbed.com/docs/latest/reference/storage.html#block-devices)

This comment has been minimized.

@offirko

offirko Oct 16, 2018

Contributor

Typo: class instead of classes

@0xc0170 0xc0170 requested a review from AnotherButler Oct 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 17, 2018

@AnotherButler Please review the readme file

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 19, 2018

@theamirocohen Curious. What was the reason for removing the PR type from the description?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 21, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 21, 2018

@theamirocohen there are some build errors in the build, please take a look

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 22, 2018

@theamirocohen It looks like this also needs to be rebased.

Will manually restart the CI pipeline once the PR is updated, assuming GitHub is still experiencing issues.

@theamirocohen theamirocohen force-pushed the theamirocohen:block_device_general_tests branch from e587d27 to 7962e0c Oct 23, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 23, 2018

seems to be rebased now.
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3437
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8430/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 23, 2018

failure seems unrelated. rechecking
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 23, 2018

/morph build

@cmonr cmonr added needs: work and removed needs: CI labels Oct 23, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 23, 2018

@theamirocohen Any more commits you'd like to add to the PR?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 23, 2018

Oh, I need to put a sock in my mouth. Didn't notice that commit fixed something...

@cmonr cmonr added needs: CI and removed needs: work labels Oct 23, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3442
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8430/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 2a50409 into ARMmbed:master Oct 23, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 674 files (+1 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10315 cycles (+1274 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 23, 2018

@theamirocohen theamirocohen deleted the theamirocohen:block_device_general_tests branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment