New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing define in drivers/SerialWireOutput.h #8442

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
6 participants
@wlamprecht

wlamprecht commented Oct 16, 2018

Description

In drivers/SerialWireOutput.h the defineMBED_SERIALWIREOUTPUT_H was missing

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 added the needs: CI label Oct 16, 2018

@0xc0170 0xc0170 changed the title from Added missing define in drivers/SerialWireOutput.h to Add missing define in drivers/SerialWireOutput.h Oct 16, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

@wlamprecht Out of curiosity, how was the missing #define found?

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3378
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8442/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

Poop. IAR network license issue.
/morph mbed2-build

@cmonr cmonr merged commit 4600c85 into ARMmbed:master Oct 17, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 666 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10568 cycles (+1428 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 17, 2018

@wlamprecht

This comment has been minimized.

wlamprecht commented Oct 31, 2018

@wlamprecht Out of curiosity, how was the missing #define found?

@cmonr I was compiling a BLE UART example and it threw an error without this define

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment