New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS : Add missing M33 and M33F in python scripts #8449

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
5 participants
@jeromecoutant
Contributor

jeromecoutant commented Oct 17, 2018

Description

Tried to complete CORTEX_M33 coverage in python scripts.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested review from theotherjimmy and deepikabhavnani Oct 17, 2018

@cmonr

cmonr approved these changes Oct 17, 2018

Show resolved Hide resolved tools/targets/__init__.py

@cmonr cmonr added the needs: review label Oct 17, 2018

@cmonr cmonr requested a review from bridadan Oct 17, 2018

@bridadan

I'm not super familiar with these cores yet, but the changes look ok to me.

@@ -413,6 +413,8 @@ def __init__(self, target, *args, **kwargs):
self.flags['common'].append("-mfloat-abi=softfp")
elif target.core.startswith("Cortex-M23"):
self.flags['common'].append("-march=armv8-m.base")
elif target.core.startswith("Cortex-M33"):

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Oct 17, 2018

Contributor

Cortex-M33 CPU specific flags are covered here.. https://github.com/ARMmbed/mbed-os/pull/8449/files#diff-9cf75aea879b6b9cc5026af0b8f708a3R396

No need of arch flag for M33 as we give add cpu flag, we should be just adding floating point here for F option.

Just FYI- Special case of non-floating point related is covered here for Cortex-M23 since we do not specify CPU but arch only. Can still be moved here https://github.com/ARMmbed/mbed-os/pull/8449/files#diff-9cf75aea879b6b9cc5026af0b8f708a3R403.

This comment has been minimized.

@deepikabhavnani

deepikabhavnani Oct 26, 2018

Contributor

-mcpu=cortex-m33+nodsp and -mfpu=none Is already set, so addition of -march is not needed here. Code should be updated to:

elif target.core.startswith("Cortex-M33F"): 
    self.flags['common'].append("-mfpu=fpv5-sp-d16")
    self.flags['common'].append("-mfloat-abi=softfp")

@cmonr cmonr added needs: work and removed needs: review labels Oct 17, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 25, 2018

@jeromecoutant Can you please review the latest @deepikabhavnani review?

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Oct 25, 2018

Can you please review the latest @deepikabhavnani review?

Mmm, not easy for me... I am not a M33 expert...
I started this PR, I would trust ARM expert for conclusion

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 29, 2018

@theotherjimmy Mind reviewing?

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_M33 branch from 7b1dcf6 to 199854f Nov 5, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Nov 5, 2018

Hi @deepikabhavnani
I tried to update files thanks to your comment.
Thx

@deepikabhavnani

@jeromecoutant - Changes look good, just small nit for code duplication

Show resolved Hide resolved tools/toolchains/gcc.py Outdated
Show resolved Hide resolved tools/toolchains/gcc.py
Show resolved Hide resolved tools/toolchains/gcc.py Outdated
Show resolved Hide resolved tools/toolchains/gcc.py Outdated

@jeromecoutant jeromecoutant force-pushed the jeromecoutant:PR_M33 branch from cac8ca5 to ba86a53 Nov 5, 2018

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Nov 5, 2018

I squashed all your suggestion

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 7, 2018

Note: This PR is now a part of a rollup PR (#8663).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit ba86a53 into ARMmbed:master Nov 7, 2018

14 checks passed

continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/build-ARM Success
Details
jenkins-ci/build-GCC_ARM Success
Details
jenkins-ci/build-IAR Success
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 545 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9860 cycles (-382 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Nov 7, 2018

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_M33 branch Nov 7, 2018

@cmonr cmonr removed the rollup PR label Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment