Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added missing _mutex->unlock() to FileBase::lookup(). #8451
My modified Pelion Device Management Client has been getting stuck in the startup for a while now. After days of debugging, I finally was able to pinpoint the system to a mutex deadlock.
I don't thought understand how this has worked with the already released PDMC.
Pull request type
I do recall seeing this error during development of #7924.
I corrected it by changing to
ScopedLock<PlatformMutex>, but when that was rejected during review, I dropped the commit, forgetting that the commit was actually fixing this mutex bug, not just a style adjustment. Whoops.
You could switch to
ScopedLock again, but this is okay.
I think we've not seen a problem because it's a recursive mutex, so wouldn't show any issues until you've got two threads doing file opening (with at least one using
Build number : 3380
Build number : 3387
Build number : 3019