New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed lorawan unittests valgrind issues #8453

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@AnttiKauppila
Contributor

AnttiKauppila commented Oct 17, 2018

Description

LoRaWAN unit tests are having lots of valgrind issues because of unitialized variables
Those are now fixed

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Oct 17, 2018

@hasnainvirk please review

@@ -64,7 +65,9 @@ TEST_F(Test_LoRaMac, initialize)
object->bind_phy(phy);
lorawan_connect_t conn;
memset(&conn, 0, sizeof(conn));

This comment has been minimized.

@kjbracey-arm

kjbracey-arm Oct 17, 2018

Contributor

This is more elegantly and correctly done as lorawan_connect_t conn = { 0 };, although GCC sometimes annoyingly and pointlessly complains about missing braces.

In C++98 you can also do lorawan_connect_t conn = lorawan_connect_t();

C++11 would allow the terser lorawan_connect_t conn{};

@hasnainvirk

Looks good

@cmonr

cmonr approved these changes Oct 17, 2018

@cmonr cmonr added the needs: CI label Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

@AnttiKauppila Thanks for the fix!
Puts into the context the quick fix that @hasnainvirk was able to do yesterday.

@hasnainvirk

This comment has been minimized.

Contributor

hasnainvirk commented Oct 17, 2018

@cmonr Yesterday we had 1 hour for the fix. So made sure that valgrind warnings were not fatal. And today Antti completes the task with zero warnings. Thanks for the support.

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

IAR network license issues.
/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

Build : SUCCESS

Build number : 3385
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8453/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Oct 17, 2018

@cmonr cmonr merged commit c8ada37 into ARMmbed:master Oct 17, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 667 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10291 cycles (+1185 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 17, 2018

@AnttiKauppila AnttiKauppila deleted the AnttiKauppila:valgrind_fixes branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment