New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Laird BL654 as a new MTB target #8454

Merged
merged 3 commits into from Oct 18, 2018

Conversation

Projects
None yet
4 participants
@ashok-rao
Contributor

ashok-rao commented Oct 17, 2018

Description

NOTE: This PR is same as #8375 . Closing the previous one (8375) and creating this due to (possible) merge conflicts as commented by @cmonr here and here Adding new MTB target for Laird BL654.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

New Target addition for Laird BL654 module.

Greentea logs also attached here again for quick access.
BL654_ARMCC_GT_Pass_log.txt
BL654_GCC_GT_Pass_log.txt
BL654_IAR_GT_Pass_log.txt

@cmonr @0xc0170 : I'm now closing the PR #8375 and opening this one. Could you please re-review? Thanks.

@cmonr

Just some minor nits, and we can start CI

PinDef(0 , 31),
PinDef(1 , 0), //P1_1 = 32...
PinDef(1 , 1),

This comment has been minimized.

@cmonr

cmonr Oct 17, 2018

Contributor

Minor nit. Could you fix the indentation?

//MTB aliases
GP0 = SIO_33,
GP1 = SIO_34,
AIN0 = SIO_2,

This comment has been minimized.

@cmonr

cmonr Oct 17, 2018

Contributor

Alignment nit

@cmonr cmonr added the needs: work label Oct 17, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 17, 2018

@cmonr : Thanks! Review comments now addressed!

@cmonr cmonr added needs: CI and removed needs: work labels Oct 17, 2018

@cmonr

cmonr approved these changes Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 17, 2018

@cmonr cmonr added needs: work and removed needs: CI labels Oct 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 17, 2018

This target is either missing QSPI pin definitions, or should not have QSPI marked as a supported feature.

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 18, 2018

Thanks @cmonr & @0xc0170 . QSPI pins now added. Can you please check again?

@cmonr

cmonr approved these changes Oct 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 18, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: work labels Oct 18, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 18, 2018

Build : SUCCESS

Build number : 3401
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8454/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit e942582 into ARMmbed:master Oct 18, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 671 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9122 cycles (-1197 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Oct 18, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Oct 19, 2018

Thanks @cmonr and @0xc0170 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment