New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: write size first when writing an eeprom message #8483

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
6 participants
@paul-szczepanek-arm
Member

paul-szczepanek-arm commented Oct 19, 2018

Description

When writing an ndef message into eprom the bytes were being written before setting the size - thus resulting in a truncated message. This fix sets the size first and writes the bytes later. Verified using the example nfceeprom app.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
@pan-

pan- approved these changes Oct 19, 2018

@ConradBraam

This comment has been minimized.

Contributor

ConradBraam commented on d5edd3f Oct 19, 2018

test code no longer reproduces the issue, good from my side

@cmonr

cmonr approved these changes Oct 19, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 21, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 21, 2018

Build : SUCCESS

Build number : 3419
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8483/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr removed the ready for merge label Oct 22, 2018

@cmonr cmonr merged commit ecb6e6e into ARMmbed:master Oct 23, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 672 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10217 cycles (+480 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment