New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework make.py CLI to avoid treating apps as tests #8538

Merged
merged 3 commits into from Nov 1, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Oct 24, 2018

Description

Prior to this changeset, applications were all compiled as test #0. This
can lead to unexpected behavoir. In particluar, it's weirdly impossible
to use a .mbedignore file to ignore
mbed-os/features/unsupported/tests/mbed/env/test_env.cpp.

This PR stops treating applications like tests.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:rework-make-cli branch from f411e30 to 679669d Oct 24, 2018

theotherjimmy added some commits Oct 24, 2018

Rework make.py Ct pLI to avoid treating apps as tests
Prior to this changeset, applications were all compiled as test #0. This
can lead to unexpected behavoir. In particluar, it's weirdly impossible
to use a `.mbedignore` file to ignore
`mbed-os/features/unsupported/tests/mbed/env/test_env.cpp`.

This PR stops treating applications like tests.

    [x] Fix
    [ ] Refactor
    [ ] Target update
    [ ] Functionality change
    [ ] Docs update
    [ ] Test update
    [ ] Breaking change

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:rework-make-cli branch from 679669d to 81013e9 Oct 24, 2018

@theotherjimmy theotherjimmy force-pushed the theotherjimmy:rework-make-cli branch from bd2ed19 to 8f07b9e Oct 24, 2018

@brianesquilona

Tested to compile Daplink cli support.

@cmonr cmonr requested review from bridadan and cmonr Oct 24, 2018

@cmonr cmonr added the needs: review label Oct 24, 2018

@bridadan

Pending my two questions below, changes look good to me.

if options.source_dir is not None:
test.source_dir = options.source_dir
build_dir = options.source_dir

This comment has been minimized.

@bridadan

bridadan Oct 25, 2018

Contributor

I can't seem to find the equivalent of lines 268-270 in the revised make.py. It looks like in the old make.py, if --source was specified and it was building tests, it would reassign the test's source dir as well as the build dir to the specified --source directory. Now this old behavior doesn't make much sense to me so I'm fine with the removal, but just wanted to make sure that it was removed for a similar reason.

This comment has been minimized.

@theotherjimmy

theotherjimmy Oct 31, 2018

Contributor

Above, a --source without a --build causes an argument error, so this line was never executed.

This comment has been minimized.

@bridadan

bridadan Oct 31, 2018

Contributor

Good point!

print('Update Image: %s' % update_file)
print('Image: %s' % bin_file)
if options.disk:

This comment has been minimized.

@bridadan

bridadan Oct 25, 2018

Contributor

Looks like the flashing, reset, and a serial output was removed as well. I'm totally fine with this, especially since this is handled by Mbed CLI now. Just making sure the removal was for similar reasons.

This comment has been minimized.

@theotherjimmy

theotherjimmy Oct 31, 2018

Contributor

That's why they were removed.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3524
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8538/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Nov 1, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit 9c5fc7d into ARMmbed:master Nov 1, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 677 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10068 cycles (+843 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the needs: CI label Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment