Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix using an optional feature before checking for support #8556

Merged
merged 1 commit into from Oct 29, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

@paul-szczepanek-arm paul-szczepanek-arm commented Oct 26, 2018

Description

Feature is optional and we must check the controller for support before trying to use it. Detected and fix validated through clitest suite of BLE tests.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm changed the title check for feature before using BLE: fix using an optional feature before checking for support Oct 26, 2018
Copy link
Member

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Oct 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 27, 2018

Build : SUCCESS

Build number : 3486
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8556/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 27, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 28, 2018

Might have had an issue with the Jenkins instance. Restarting to confirm.

/morph export-build
/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 28, 2018

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Build : SUCCESS

Build number : 3488
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8556/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@paul-szczepanek-arm
Copy link
Member Author

IAR Lincense error in the first log I looked into.

@NirSonnenschein
Copy link
Contributor

good point: re-running export: /morph export-build

@NirSonnenschein
Copy link
Contributor

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 29, 2018

To confirm the issue (not related to this changeset but rather to master)

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

@cmonr cmonr merged commit 1489900 into ARMmbed:master Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants